PersonalPublic/fastapi-sqlalchemy-asyncpg
1
0
Fork 0
mirror of https://github.com/grillazz/fastapi-sqlalchemy-asyncpg.git synced 2025-08-26 16:40:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor: introduce pydantic SecretStr to protect sensitive information like user password

Browse Source
This commit is contained in:
Jakub Miazek 2024-03-29 14:12:32 +01:00
parent 37c5bb316f
commit 68e73d60ec
2 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/models/user.py
View File

@ -3,6 +3,7 @@ from typing import Any
import bcrypt import bcrypt
from passlib.context import CryptContext from passlib.context import CryptContext
from pydantic import SecretStr
from sqlalchemy import String, LargeBinary, select from sqlalchemy import String, LargeBinary, select
from sqlalchemy.dialects.postgresql import UUID from sqlalchemy.dialects.postgresql import UUID
from sqlalchemy.ext.asyncio import AsyncSession from sqlalchemy.ext.asyncio import AsyncSession
@ -25,11 +26,12 @@ class User(Base):
return self._password.decode("utf-8") return self._password.decode("utf-8")
@password.setter @password.setter
def password(self, password: str): def password(self, password: SecretStr):
self._password = bcrypt.hashpw(password.encode("utf-8"), bcrypt.gensalt()) _password_string = password.get_secret_value()
self._password = bcrypt.hashpw(_password_string.encode("utf-8"), bcrypt.gensalt())
def check_password(self, password: str): def check_password(self, password: SecretStr):
return pwd_context.verify(password, self.password) return pwd_context.verify(password.get_secret_value(), self.password)
@classmethod @classmethod
async def find(cls, database_session: AsyncSession, where_conditions: list[Any]): async def find(cls, database_session: AsyncSession, where_conditions: list[Any]):

14
app/schemas/user.py
View File

@ -1,6 +1,6 @@
from uuid import UUID from uuid import UUID
from pydantic import BaseModel, Field, EmailStr, ConfigDict from pydantic import BaseModel, Field, EmailStr, ConfigDict, SecretStr
config = ConfigDict(from_attributes=True) config = ConfigDict(from_attributes=True)
@ -8,10 +8,10 @@ config = ConfigDict(from_attributes=True)
# TODO: add pydantic field validator for strong password # TODO: add pydantic field validator for strong password
class UserSchema(BaseModel): class UserSchema(BaseModel):
model_config = config model_config = config
email: EmailStr = Field(title="User’s email", description="User’s email") email: EmailStr = Field(title="User’s email", description="User’s email", examples=["john@domain.com"])
first_name: str = Field(title="User’s first name", description="User’s first name") first_name: str = Field(title="User’s first name", description="User’s first name", examples=["John"])
last_name: str = Field(title="User’s last name", description="User’s last name") last_name: str = Field(title="User’s last name", description="User’s last name", examples=["Doe"])
password: str = Field(title="User’s password", description="User’s password") password: SecretStr = Field(title="User’s password", description="User’s password", examples=["@SuperSecret123"])
class UserResponse(BaseModel): class UserResponse(BaseModel):
@ -29,5 +29,5 @@ class TokenResponse(BaseModel):
class UserLogin(BaseModel): class UserLogin(BaseModel):
model_config = config model_config = config
email: EmailStr = Field(title="User’s email", description="User’s email") email: EmailStr = Field(title="User’s email", description="User’s email", examples=["john@domain.com"])
password: str = Field(title="User’s password", description="User’s password") password: SecretStr = Field(title="User’s password", description="User’s password", examples=["@SuperSecret123"])